[dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping

[Wu, Jingjing]

NACK it.

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wu, Jingjing
> Sent: Saturday, September 9, 2017 11:22 AM
> To: Zang MingJie <zealot0630 at gmail.com>; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zang MingJie
> > Sent: Thursday, August 24, 2017 9:29 PM
> > To: dev at dpdk.org
> > Cc: Zang MingJie <zealot0630 at gmail.com>
> > Subject: [dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping
> >
> > Function i40e_vsi_config_vlan_stripping doesn't strip vlan tag for vf.
> > The patch should fix the problem.
> >
> > Signed-off-by: Zang MingJie <zealot0630 at gmail.com>
> > ---
> >  drivers/net/i40e/i40e_ethdev.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > b/drivers/net/i40e/i40e_ethdev.c index 5f26e24a3..cd48ebbc1 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -5189,7 +5189,7 @@ i40e_vsi_config_vlan_stripping(struct i40e_vsi *vsi,
> bool on)
> >  	}
> >
> >  	if (on)
> > -		vlan_flags = I40E_AQ_VSI_PVLAN_EMOD_STR_BOTH;
> > +		vlan_flags = I40E_AQ_VSI_PVLAN_EMOD_STR;
> >  	else
> >  		vlan_flags = I40E_AQ_VSI_PVLAN_EMOD_NOTHING;
> >  	vsi->info.valid_sections =
> 
> How did you find this issue? In our cases, it works well.
> And according to the datasheet, the EMOD_STR meaning Hide vlan but not
> strip them to descriptor.
> 
> Thanks
> Jingjing