[dpdk-dev] [PATCH v6 0/5] increase port_id range

[Ferruh Yigit]

On 10/6/2017 3:15 AM, Ferruh Yigit wrote:
> On 9/29/2017 8:17 AM, Zhiyong Yang wrote:
>> port_id is currently defined as uint8_t, which is limited to the range
>> 0 to 255. A larger range is required for vdev scalability.
>>
>> It is necessary for a redefinition of port_id to extend it from
>> 1 bytes to 2 bytes. All ethdev APIs and usages related to port_id will
>> be changed at the same time.
>>
>> Discussion about port_id is the following thread.
>> http://www.dpdk.org/dev/patchwork/patch/23208/
>>
>> Changes in V2:
>> 1. cover more PMDs to increase port_id range.
>> 2. cover more examples to increase port_id range.
>> 3. add 17.11 release note.
>>
>> Changes in V3:
>> 1.  cover mlx4 and mlx5.
>> 2.  add to increase port_id range in test code.
>> 3.  The patch "librte_mbuf: modify port initialization value" is merged
>>     into the patchset.
>>
>> Changes in V4:
>> 1.  Add a patch to remove bonding APIs using ABI versioning according to
>>     Ferruh's comments.
>> 2.  Unify to use typedef portid_t in testpmd code.
>> 3.  update release note deprecation doc in 2/5
>> 4.  fix some issues according to comments.
>>
>> Changes in V5:
>> 1.  For 1/5, bond_mode_8023ad_conf_get_v1708() and bond_mode_8023ad_conf
>>     _get() are merged into one function bond_mode_8023ad_conf_get.
>>
>> Changes in V6:
>> 1.  For 2/5, remove the unnecessary LIBABIVER in Makefile and update
>>     the release notes "Shared Library Versions".
>>     Note: The patchset have dependency on the following patch.
>>     http://www.dpdk.org/dev/patchwork/patch/28738/
>>     http://www.dpdk.org/dev/patchwork/patch/29219/
>>
>> Note: 3/5 and 4/5 patches' building depends on 2/5 patch since 2/5 patch
>> breaks lib/PMD API/ABI.
>>
>> Zhiyong Yang (5):
>>   net/bonding: remove bonding APIs using ABI versioning
>>   ethdev: increase port_id range
>>   examples: increase port_id range
>>   test: increase port_id range
>>   librte_mbuf: modify port initialization value
> 
> Series applied to dpdk-next-net/master, thanks.

Hi Zhiyong,

I can see there are more "uint8_t port_id" usage in testpmd:

$ git grep -c "uint8_t port_id"
cmdline.c:93
config.c:7
testpmd.c:4
testpmd.h:8

I believe there can be false-positives, but can you please check and
send a fix patch if required?

Thanks,
ferruh

<...>