[dpdk-dev] [PATCH v4 00/16] add net mrvl pmd driver

[Ferruh Yigit]

On 10/9/2017 9:59 PM, Ferruh Yigit wrote:
> On 10/9/2017 4:00 PM, Tomasz Duszynski wrote:
>> Hello,
>>
>> This patch series introduces the net driver for Marvell Armada 7k/8k
>> SoCs along with documentation.
>>
>> Below you can find the list of features which net pmd supports:
>> * Speed capabilities
>> * Link status
>> * MTU update
>> * Jumbo frame
>> * Promiscuous mode
>> * Allmulticast mode
>> * Unicast MAC filter
>> * Multicast MAC filter
>> * RSS hash
>> * VLAN filter
>> * CRC offload
>> * L3 checksum offload
>> * L4 checksum offload
>> * Packet type parsing
>> * Basic stats
>> * QoS
>>
>> Changes since v3:
>> * Split driver into skeleton, rx/tx, features, documentation parts
>> * Added speed capabilities flags.
>> * Added missing rx offload flags: VLAN/JUMBOFRAME
>> * Updated release notes.
>> * Updated documentation.
>>
>> Changes since v2:
>> * Removed LINE_SPACING, MULTILINE_DEREFERENCE and SPLIT_STRING
>>   checkpatch warnings.
>> * Removed unnecessary forward declarations.
>> * Fixed whitespace warnings.
>>
>> Changes since v1:
>> * Changed commit message to explain problem better.
>> * Removed bunch of checkpatch warnings about unnecessary parentheses.
>>
>> Tomasz Duszynski (4):
>>   app: link the whole rte_cfgfile library
>>   net/mrvl: add mrvl net pmd driver skeleton
>>   net/mrvl: add rx/tx support
>>   net/mrvl: add link update
>>   net/mrvl: add link speed capabilities
>>   net/mrvl: add support for updating mtu
>>   net/mrvl: add jumbo frame support
>>   net/mrvl: add support for promiscuous and allmulticast modes
>>   net/mrvl: add support for mac filtering
>>   net/mrvl: add rss hashing support
>>   net/mrvl: add support for vlan filtering
>>   net/mrvl: add crc, l3 and l4 offloads support
>>   net/mrvl: add packet type parsing support.
>>   net/mrvl: add basic stats support
>>   maintainers: add maintainers for the mrvl net pmd
>>   doc: add mrvl net pmd documentation
> 
> Series applied to dpdk-next-net/master, thanks.
> 
> (I can't compile because of missing musdk library, but since PMD is
> disabled by default this is not so bad, lets get this for rc1 and for
> crypto dependency, later I can have my environment set and test)

Did able to compile but I have questions :)

1- Used the "arm64-armv8a-linuxapp-gcc" config, can you please confirm.
Does it make sense to document this?

2- I used different toolchain than documented in musdk, which uses a
marvel one. Can you please confirm any aarch64-linux-gnu-gcc is OK?

3- Used following command:
CROSS=<toolchain>/aarch64-linux-gnu- make
EXTRA_CFLAGS="-I.../musdk-marvell/src/include
-L.../musdk-marvell/src/.libs/"

Do you also need to use EXTRA_CFLAGS? Otherwise I can't compile. If you
also use it please document it, if not please share with us how to do?

4- musk generated a static library, can you please confirm there is a
way to generate a shared musdk library as well?

5- Still not tested building kernel modules, and building musdk with
./configure options, I will do later.

Thanks,
ferruh