[dpdk-dev] [PATCH] crypto/dpaa_sec: remove memset of icv on decryption side

Akhil Goyal akhil.goyal at nxp.com
Fri Oct 13 16:22:51 CEST 2017


On 10/12/2017 6:37 PM, alok.makhariya at nxp.com wrote:
> From: Alok Makhariya <alok.makhariya at nxp.com>
> 
> Since the packet lengths are modified. It is not required to
> explicitly reset the icv.
> Fixes: 89aaf708d44b ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform")
> 
> Signed-off-by: Alok Makhariya <alok.makhariya at nxp.com>
> ---
>   drivers/crypto/dpaa_sec/dpaa_sec.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c
> index 8a57b96..b618b59 100644
> --- a/drivers/crypto/dpaa_sec/dpaa_sec.c
> +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c
> @@ -598,7 +598,6 @@ build_auth_only(struct rte_crypto_op *op, dpaa_sec_session *ses)
>   		/* hash result or digest, save digest first */
>   		rte_memcpy(old_digest, sym->auth.digest.data,
>   			   ses->digest_length);
> -		memset(sym->auth.digest.data, 0, ses->digest_length);
>   		qm_sg_entry_set64(sg, start_addr + sym->auth.data.offset);
>   		sg->length = sym->auth.data.length;
>   		cpu_to_hw_sg(sg);
> @@ -738,7 +737,6 @@ build_cipher_auth_gcm(struct rte_crypto_op *op, dpaa_sec_session *ses)
>   
>   		memcpy(ctx->digest, sym->aead.digest.data,
>   		       ses->digest_length);
> -		memset(sym->aead.digest.data, 0, ses->digest_length);
>   		sg++;
>   
>   		qm_sg_entry_set64(sg, dpaa_mem_vtop(ctx->digest));
> @@ -832,7 +830,6 @@ build_cipher_auth(struct rte_crypto_op *op, dpaa_sec_session *ses)
>   
>   		memcpy(ctx->digest, sym->auth.digest.data,
>   		       ses->digest_length);
> -		memset(sym->auth.digest.data, 0, ses->digest_length);
>   		sg++;
>   
>   		qm_sg_entry_set64(sg, dpaa_mem_vtop(ctx->digest));
> 
Acked-by Akhil Goyal <akhil.goyal at nxp.com>


More information about the dev mailing list