[dpdk-dev] [PATCH 1/2] net/tap: fix indentation in flow file

Pascal Mazon pascal.mazon at 6wind.com
Mon Oct 16 10:04:50 CEST 2017


Sorry for the delay, I was on vacation.

Nevermind this indent patch for now.
Matan, could you integrate it (squashed) when you'll have a new patch
modifying tap_flow.c?

Thank you.


On 05/10/2017 23:33, Ferruh Yigit wrote:
> On 10/4/2017 6:26 PM, Ferruh Yigit wrote:
>> On 10/4/2017 9:15 AM, Pascal Mazon wrote:
>>> Hi,
>>> I'm surprised there's only one place in the file with indent problem,
>>> but I'm ok with the patch otherwise.
>>> Ferruh, I didn't get what you mean; Matan is modifying tap_flow.c in
>>> patch 2/2, right?
>> I wasn't sure about getting the patch that fixes only syntax in one place.
>> Good to have proper syntax but a commit for this looked like overkill to
>> me. So I was suggesting keep it as it is and fix syntax when that piece
>> of code updated later.
>> But you are the maintainer of the driver, if you have strong opinion to
>> get it, sure I can.
> What has been fixed is still in next-net, so I can squash this.
> <...>
>>>>> Missed 4 spaces were added after break if line.
>>>>> Fixes: 7a6811d78ed6 ("net/tap: fix flow and port commands")
>>>> What do you think fixing this when that code has been touched next time?
>>>>> Signed-off-by: Matan Azrad <matan at mellanox.com>
> Squashed into relevant commit in next-net, thanks.

More information about the dev mailing list