[dpdk-dev] [PATCH dpdk v2] vfio/ppc64/spapr: Warn if DMA window was created at unexpected offset
thomas at monjalon.net
Tue Oct 17 18:13:14 CEST 2017
28/04/2017 13:19, Burakov, Anatoly:
> From: Alexey Kardashevskiy
> > VFIO_IOMMU_SPAPR_TCE_CREATE ioctl() returns the actual bus address for
> > just created DMA window. It happens to start from zero because the default
> > window is removed (leaving no windows) and new window starts from zero.
> > However this is not guaranteed and a new window may start from another
> > address, this adds a check and an error message.
> > Signed-off-by: Alexey Kardashevskiy <aik at ozlabs.ru>
> > ---
> > Changes:
> > v2:
> > * this just prints warning and fails instead of incorrectly changing IOVA
> > addresses
> > ---
> Hi Alexey,
> There are some compile failures with this patch. You'll probably want to replace %lx with PRIx64 or similar :)
> I would argue that just saying "DMA offsets other than zero are not supported" will be sufficient and will make error message less confusing. Up to you though.
Please, can we progress on this patch?
Is it still a relevant patch?
If yes, someone to make a v3, please?
More information about the dev