[dpdk-dev] [PATCH v5 10/20] pci: avoid inlining functions

Gaëtan Rivet gaetan.rivet at 6wind.com
Wed Oct 18 10:54:32 CEST 2017


On Tue, Oct 17, 2017 at 02:20:45PM -0400, Aaron Conole wrote:
> Gaetan Rivet <gaetan.rivet at 6wind.com> writes:
> 
> > Parsing operations should not happen in performance critical sections.
> > Headers should not propose implementations unless duly required.
> >
> > Signed-off-by: Gaetan Rivet <gaetan.rivet at 6wind.com>
> > ---
> 
> Can these cleanups be done before the move in patch 3?

Sure.

I wanted to minimize the changes before moving the code. If I had rework
to do on these patches, I wanted to avoid having to redo the move and
verify the changes were properly propagated.

But if it is necessary, these changes can happen before moving the whole
lot.

-- 
Gaëtan Rivet
6WIND


More information about the dev mailing list