[dpdk-dev] [PATCH 2/2] ethdev: pre-emptively document rte_eth_dev_reset error code

luca.boccassi at gmail.com luca.boccassi at gmail.com
Thu Oct 19 15:48:27 CEST 2017


From: Luca Boccassi <bluca at debian.org>

When VF reset will be supported by drivers, the API will most likely
have to return -EAGAIN to avoid blocking when the VF cannot be reset
because the PF is down.
Document it immediately even if it's not yet supported, so that users
and developers can already take into account about this use case, and
thus avoid an API-incompatible change later on.

This is based on real-world production usage and customer escalations,
using earlier patches from Intel.

Signed-off-by: Luca Boccassi <bluca at debian.org>
---
 lib/librte_ether/rte_ethdev.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 9cdb9724a..126f42d3c 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -2270,6 +2270,7 @@ void rte_eth_dev_close(uint16_t port_id);
  *   - (-EPERM) if not ran from the primary process.
  *   - (-EIO) if re-initialisation failed.
  *   - (-ENOMEM) if the reset failed due to OOM.
+ *   - (-EAGAIN) if PF is not up and the reset cannot proceed yet.
  */
 int rte_eth_dev_reset(uint16_t port_id);
 
-- 
2.11.0



More information about the dev mailing list