[dpdk-dev] [PATCH 05/11] examples/ipsec-secgw: Fixed transport
De Lara Guarch, Pablo
pablo.de.lara.guarch at intel.com
Thu Oct 19 20:16:25 CEST 2017
> -----Original Message-----
> From: Aviad Yehezkel [mailto:aviadye at dev.mellanox.co.il]
> Sent: Monday, October 16, 2017 11:42 AM
> To: Gonzalez Monroy, Sergio <sergio.gonzalez.monroy at intel.com>;
> dev at dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>;
> aviadye at mellanox.com
> Cc: borisp at mellanox.com; akhil.goyal at nxp.com;
> hemant.agrawal at nxp.com; Nicolau, Radu <radu.nicolau at intel.com>;
> Doherty, Declan <declan.doherty at intel.com>; liranl at mellanox.com;
> nelio.laranjeiro at 6wind.com; thomas at monjalon.net
> Subject: Re: [dpdk-dev][PATCH 05/11] examples/ipsec-secgw: Fixed
> On 10/16/2017 12:30 PM, Sergio Gonzalez Monroy wrote:
> > On 14/10/2017 14:27, aviadye at dev.mellanox.co.il wrote:
> >> From: Aviad Yehezkel <aviadye at mellanox.com>
> >> Seems like transport was broken for a long time
> > Commit message needs to be improved. Just mentioned what is wrong or
> > how do you fix it.
> > Given that it is a fix, you should start the commit title with "fix
> > ..." then also add the 'fixes' line with commit that added the bug.
> > That way you can easily see since when it was introduced.
> > Thanks,
> > Sergio
> Will create such commit messages for future fixes as you instructed above.
> I will remove this patch from next version of fixes since there is a similar fix
> already provided by Tomasz Duszynski which I will review.
Will you send a v2 of this patchset soon?
More information about the dev