[dpdk-dev] [PATCH v4 09/12] mk: add rte security into build system

Akhil Goyal akhil.goyal at nxp.com
Sat Oct 21 21:44:11 CEST 2017


Hi Thomas,

On 10/20/2017 4:36 PM, Thomas Monjalon wrote:
> Why not merging this patch with the first one?
There are some code changes in ethdev and cryptodev(subsequent patches) 
which are used in the first patch. This would break compilation.
So compilation of the lib is done in the last to avoid compilation issues.
> 
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> +Security API - EXPERIMENTAL
>> +M: Akhil Goyal <akhil.goyal at nxp.com>
>> +M: Declan Doherty <declan.doherty at intel.com>
>> +T: git://dpdk.org/draft/dpdk-draft-ipsec
>> +F: lib/librte_security/
>> +F: doc/guides/prog_guide/rte_security.rst
> 
> Do you really want to keep this draft tree?
> If no, please do not reference it.
ok, will remove it.
> 
>> +# Compile generic security library
>> +#
>> +CONFIG_RTE_LIBRTE_SECURITY=y
>> +CONFIG_RTE_LIBRTE_SECURITY_DEBUG=n
> 
> No, DEBUG config options are prohibited.
> The new log system allows to change the log level dynamically.
ok will remove it
> 
> It was mentioned a lot of time in other patch series.
> I was in the hope that everybody was now aware of the new log system
> and the desire of removing all DEBUG options.
> 
> 

Thanks,
Akhil


More information about the dev mailing list