[dpdk-dev] [PATCH v1 1/2] mempool/octeontx: move mbox from event to mempool

Thomas Monjalon thomas at monjalon.net
Mon Oct 23 16:50:27 CEST 2017

16/10/2017 15:42, Santosh Shukla:
> Octeontx mempool pmd need mailbox for pool setup.
> That mailbox was defined at drivers/event/octeontx.
> So mempool has dependency on event/octeontx driver and
> commit:8700239f7767 has added make rule which makes sure event/*
> get build before mempool, but this rule introduces
> cyclic dependency and may create problem to future
> feature addition in drivers/Makefile.
> Same problem noticed and reported in below thread:
> http://dpdk.org/ml/archives/dev/2017-October/079187.html
> The patch solves problem by moving mbox definition from
> drivers/event/octeontx to drivers/mempool/octeontx.
> Moving mbox files involves below changes:
> * Renamed ssovf_mbox.[ch] --> octeontx_mbox.[ch]
> * Renamed ssovf_probe.c  --> octeontx_ssovf.c
> * Introduced pool logger file.
> * Moved API from rte_pmd_octeontx_ssovf_version.map to
>   rte_mempool_octeontx_version.map.
> * Respective Makefile changes done in
>   drivers/event/octeontx/Makefile and drivers/mempool/octeontx/Makefile.
> Fixes: 8700239f7767 ("mempool/octeontx: add build and log infrastructure")
> Reported-by: Hemant Agrawal <hemant.agrawal at nxp.com>
> Signed-off-by: Santosh Shukla <santosh.shukla at caviumnetworks.com>

There is a 32-bit compilation issues:

-       fpavf_log_dbg("buffer exist in pool cnt %ld\n", cnt);
+       fpavf_log_dbg("buffer exist in pool cnt %" PRId64 "\n", cnt);

Fixed when applying

More information about the dev mailing list