[dpdk-dev] [PATCH] net/sfc: fix Tx reap behaviour on port stop on EF10 datapath
ferruh.yigit at intel.com
Mon Oct 23 20:08:43 CEST 2017
On 10/18/2017 2:39 AM, Andrew Rybchenko wrote:
> From: Ivan Malov <ivan.malov at oktetlabs.ru>
> Tx reap mechanism on EF10 native datapath was altered by one
> of the recent patches to introduce performance optimisations
> using the common technique of freeing mbuf segments in bulks.
> From this perspective, the way of associating SW descriptors
> with individual mbuf segments rather than with whole packets
> was adopted as a key requirement for the entire optimisation.
> However, only the fast path reap function was amended to fit
> the new scheme whilst the corresponding function on the port
> stop path was left intact by mistake. This implies incorrect
> usage of rte_pktmbuf_free() with regard to separate segments
> rather than calling rte_pktmbuf_free_seg() and must be fixed.
Good to know you are OK Ivan, I was worried when previous a few
commit logs were not perfectly aligned :)
> Fixes: d321954343c8 ("net/sfc: free mbufs in bulks on EF10 native Tx reap")
> Signed-off-by: Ivan Malov <ivan.malov at oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
> Reviewed-by: Andy Moreton <amoreton at solarflare.com>
Applied to dpdk-next-net/master, thanks.
More information about the dev