[dpdk-dev] [PATCH 0/3] mk: fix LDLIBS

Thomas Monjalon thomas at monjalon.net
Tue Oct 24 02:15:49 CEST 2017


23/10/2017 16:39, Eads, Gage:
> From: Olivier Matz [mailto:olivier.matz at 6wind.com]
> > 
> > Some libraries in LDLIBS are currently generated from the
> > DEPDIRS-$(dirname) variables in the Makefiles. This is valid when the
> > subdirectory name match the library name, but it's not always the case,
> > especially for PMDs.
> > 
> > This series fixes some invalid dependency declarations first, and then removes
> > the automatic generation of libraries from the directory names. Instead, the
> > libraries are explicitly added in each Makefile.
> 
> These three patches look good. I tested it on the contrived example from my original email, and this appears to fix the issue.
> 
> Once the third patch's apply issues are resolved (http://dpdk.org/ml/archives/test-report/2017-October/032631.html):
> Reviewed-by: Gage Eads <gage.eads at intel.com>

Fixed some conflicts due to new PMDs and octeontx dependencies changes.
Fixed some misses in patch 3 as explained in prior message.

Applied with some fixes, thanks


More information about the dev mailing list