[dpdk-dev] [PATCH] net/mlx4: fix targetless internal rule creation

[Matan Azrad]

The corrupted code allowed to create internal rule with no any target queue
in case the rule creation ocured before queues creation.

For example, when user calls rte_eth_dev_default_mac_addr_set after probe
and before dev_configure, mlx4 failis because the RSS queue number was 0.

The fix prevents internal rules creation before queues creation based on
future creation before traffic start.

Fixes: 7d8675956f57 ("net/mlx4: add RSS support outside flow API")

Signed-off-by: Matan Azrad <matan at mellanox.com>
---
 drivers/net/mlx4/mlx4_flow.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c
index a0f431b..7a6097f 100644
--- a/drivers/net/mlx4/mlx4_flow.c
+++ b/drivers/net/mlx4/mlx4_flow.c
@@ -1290,6 +1290,9 @@ struct mlx4_drop {
 	unsigned int i;
 	int err = 0;
 
+	/* Nothing to be done if there are no Rx queues. */
+	if (!queues)
+		goto error;
 	/* Prepare default RSS configuration. */
 	*rss_conf = (struct rte_flow_action_rss){
 		.rss_conf = NULL, /* Rely on default fallback settings. */
-- 
1.8.3.1