[dpdk-dev] [dpdk-stable] [PATCH v3] examples/vhost_scsi: fix buffer not terminated

[Thomas Monjalon]

17/10/2017 15:26, Yuanhan Liu:
> On Fri, Oct 13, 2017 at 09:12:33AM +0200, Maxime Coquelin wrote:
> > On 10/12/2017 01:34 PM, Jacek Piasecki wrote:
> > >--- a/examples/vhost_scsi/scsi.c
> > >+++ b/examples/vhost_scsi/scsi.c
> > >@@ -307,7 +307,9 @@ vhost_bdev_scsi_inquiry_command(struct vhost_block_dev *bdev,
> > >  		strncpy((char *)inqdata->t10_vendor_id, "INTEL", 8);
> > >  		/* PRODUCT IDENTIFICATION */
> > >-		strncpy((char *)inqdata->product_id, bdev->product_name, 16);
> > >+		snprintf((char *)inqdata->product_id,
> > >+				ARRAY_SIZE(inqdata->product_id), "%s",
> > >+				bdev->product_name);
> > >  		/* PRODUCT REVISION LEVEL */
> > >  		strncpy((char *)inqdata->product_rev, "0001", 4);
> > 
> > Acked-by: Maxime Coquelin <maxime.coquelin at redhat.com>
> 
> Firstly, sorry for being so late response. And,
> 
> Applied to dpdk-next-virtio. Thanks!

I don't know where this ARRAY_SIZE comes from.
It does not compile.
In DPDK you can use RTE_DIM.

This patch is removed from the next-virtio pull queue.