[dpdk-dev] [PATCH v2 09/15] net/bnxt: fix an issue reported by Coverity

Ajit Khaparde ajit.khaparde at broadcom.com
Tue Oct 24 23:19:47 CEST 2017


Fixes: b7435d660a8c ("net/bnxt: add ntuple filtering support")
Coverity issue: 195015

Signed-off-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 9065a12df..c2d54efd8 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -2039,6 +2039,11 @@ bnxt_cfg_ntuple_filter(struct bnxt *bp,
 			goto free_filter;
 		STAILQ_INSERT_TAIL(&vnic->filter, bfilter, next);
 	} else {
+		if (mfilter == NULL) {
+			/* This should not happen. But for Coverity! */
+			ret = -ENOENT;
+			goto free_filter;
+		}
 		ret = bnxt_hwrm_clear_ntuple_filter(bp, mfilter);
 
 		STAILQ_REMOVE(&vnic->filter, mfilter, bnxt_filter_info,
-- 
2.13.5 (Apple Git-94)



More information about the dev mailing list