[dpdk-dev] [PATCH v3 2/3] eventdev: extend queue attribute get function
Van Haaren, Harry
harry.van.haaren at intel.com
Wed Oct 25 15:43:08 CEST 2017
> From: Pavan Nikhilesh [mailto:pbhagavatula at caviumnetworks.com]
> Sent: Monday, October 23, 2017 6:41 PM
> To: Van Haaren, Harry <harry.van.haaren at intel.com>; hemant.agrawal at nxp.com;
> jerin.jacob at caviumnetworks.com
> Cc: dev at dpdk.org; Pavan Bhagavatula <pbhagavatula at caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH v3 2/3] eventdev: extend queue attribute get
> function
>
> From: Pavan Bhagavatula <pbhagavatula at caviumnetworks.com>
>
> Add schedule type queue attribute so that it can be queried along with
> the queue config structure.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula at caviumnetworks.com>
> ---
>
> v2 changes:
> - return EOVERFLOW when schedule_type is requested and event_queue_cfg is
> set
> to *ALL_TYPES*.
>
> lib/librte_eventdev/rte_eventdev.c | 6 ++++++
> lib/librte_eventdev/rte_eventdev.h | 7 +++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/lib/librte_eventdev/rte_eventdev.c
> b/lib/librte_eventdev/rte_eventdev.c
> index db96552..fa18422 100644
> --- a/lib/librte_eventdev/rte_eventdev.c
> +++ b/lib/librte_eventdev/rte_eventdev.c
> @@ -809,6 +809,12 @@ rte_event_queue_attr_get(uint8_t dev_id, uint8_t
> queue_id, uint32_t attr_id,
> case RTE_EVENT_QUEUE_ATTR_EVENT_QUEUE_CFG:
> *attr_value = conf->event_queue_cfg;
> break;
> + case RTE_EVENT_QUEUE_ATTR_SCHEDULE_TYPE:
> + if (conf->event_queue_cfg == RTE_EVENT_QUEUE_CFG_ALL_TYPES)
> + return -EOVERFLOW;
I think event_queue_cfg is a bit-set right? The == on this line above is a bug in that case, should be &
<snip>
With above comments;
Acked-by: Harry van Haaren <harry.van.haaren at intel.com>
More information about the dev
mailing list