[dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue

[Ananyev, Konstantin]

> -----Original Message-----
> From: Nicolau, Radu
> Sent: Thursday, October 26, 2017 12:01 PM
> To: David Marchand <david.marchand at 6wind.com>
> Cc: dev at dpdk.org; Doherty, Declan <declan.doherty at intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; Hemant
> Agrawal <hemant.agrawal at nxp.com>; borisp at mellanox.com; aviadye at mellanox.com; Thomas Monjalon <thomas at monjalon.net>;
> sandeep.malik at nxp.com; Jerin Jacob <jerin.jacob at caviumnetworks.com>; Mcnamara, John <john.mcnamara at intel.com>; Ananyev,
> Konstantin <konstantin.ananyev at intel.com>; shahafs at mellanox.com; Olivier Matz <olivier.matz at 6wind.com>; Akhil Goyal
> <akhil.goyal at nxp.com>
> Subject: Re: [PATCH 2/3] net/ixgbe: fix build issue
> 
> 
> 
> On 10/26/2017 11:36 AM, David Marchand wrote:
> > On Thu, Oct 26, 2017 at 12:22 PM, Radu Nicolau <radu.nicolau at intel.com> wrote:
> >> Build fails when rte_security is disabled; make rte_security mandatory
> >> Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec")
> >>
> >> Signed-off-by: Radu Nicolau <radu.nicolau at intel.com>
> >> ---
> >>   drivers/net/ixgbe/Makefile | 6 ++++++
> >>   1 file changed, 6 insertions(+)
> >>
> >> diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
> >> index f03c426..c879828 100644
> >> --- a/drivers/net/ixgbe/Makefile
> >> +++ b/drivers/net/ixgbe/Makefile
> >> @@ -31,6 +31,12 @@
> >>
> >>   include $(RTE_SDK)/mk/rte.vars.mk
> >>
> >> +ifneq ($(MAKECMDGOALS),clean)
> >> +ifneq ($(CONFIG_RTE_LIBRTE_SECURITY),y)
> >> +$(error "RTE_LIBRTE_SECURITY is required to build RTE_LIBRTE_IXGBE_PMD")
> >> +endif
> >> +endif
> >> +
> >>   #
> >>   # library name
> >>   #
> > This is a no go for me unless you explain how it is impossible to
> > disable it in the code.
> >
> >
> It can be disabled in the code, but as far as I know there is a general
> push back against having conditionally compiled code. I originally had
> the security sections in ixgbe PMD isolated, but the feedback was to
> have them always on.
> An alternative solution will be to remove the option altogether and
> always build rte_security library.

My vote would be to have it a mandatory library for ixgbe.
Add it into DEPDIRS-ixgbe inside drivers/net/Makefile or so.
Konstantin