[dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue

[Ananyev, Konstantin]

> -----Original Message-----
> From: David Marchand [mailto:david.marchand at 6wind.com]
> Sent: Thursday, October 26, 2017 12:39 PM
> To: Ananyev, Konstantin <konstantin.ananyev at intel.com>
> Cc: Nicolau, Radu <radu.nicolau at intel.com>; dev at dpdk.org; Doherty, Declan <declan.doherty at intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch at intel.com>; Hemant Agrawal <hemant.agrawal at nxp.com>; borisp at mellanox.com; aviadye at mellanox.com;
> Thomas Monjalon <thomas at monjalon.net>; sandeep.malik at nxp.com; Jerin Jacob <jerin.jacob at caviumnetworks.com>; Mcnamara,
> John <john.mcnamara at intel.com>; shahafs at mellanox.com; Olivier Matz <olivier.matz at 6wind.com>; Akhil Goyal
> <akhil.goyal at nxp.com>
> Subject: Re: [PATCH 2/3] net/ixgbe: fix build issue
> 
> On Thu, Oct 26, 2017 at 1:30 PM, Ananyev, Konstantin
> <konstantin.ananyev at intel.com> wrote:
> >> -----Original Message-----
> >> From: Nicolau, Radu
> >> It can be disabled in the code, but as far as I know there is a general
> >> push back against having conditionally compiled code. I originally had
> >> the security sections in ixgbe PMD isolated, but the feedback was to
> >> have them always on.
> >> An alternative solution will be to remove the option altogether and
> >> always build rte_security library.
> >
> > My vote would be to have it a mandatory library for ixgbe.
> > Add it into DEPDIRS-ixgbe inside drivers/net/Makefile or so.
> 
> And then librte_security needs librte_crypto (if I am not mistaken).

It seems like it does...
Though from what I understand - it uses inly some struct definitions from it.
Wonder could we move these definitions into rte_security instead and make
rte_cryptodev depend on it instead?
Konstantin

> So if we go this way, we must ensure the same is done in librte_security.
> 
> 
> --
> David Marchand