[dpdk-dev] [PATCH] app/testpmd: remove port status check from TM hierarchy commit cli

Jasvinder Singh jasvinder.singh at intel.com
Fri Oct 27 11:46:19 CEST 2017


Some drivers might allow to commit the traffic management hierarchy
while being in running state. Therefore, removes port status check
before invoking hierarchy commit API in the cli. If needed, device can
add port status check at the driver layer.

Signed-off-by: Jasvinder Singh <jasvinder.singh at intel.com>
---
 app/test-pmd/cmdline_tm.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c
index 964ce9d..53f941c 100644
--- a/app/test-pmd/cmdline_tm.c
+++ b/app/test-pmd/cmdline_tm.c
@@ -2033,12 +2033,6 @@ static void cmd_port_tm_hierarchy_commit_parsed(void *parsed_result,
 	if (port_id_is_invalid(port_id, ENABLED_WARN))
 		return;
 
-	/* Port status */
-	if (port_is_started(port_id)) {
-		printf(" Port %u not stopped (error)\n", port_id);
-		return;
-	}
-
 	if (strcmp(res->clean_on_fail, "yes") == 0)
 		clean_on_fail = 1;
 	else
-- 
2.9.3



More information about the dev mailing list