[dpdk-dev] [PATCH v3 3/7] net/mlx4: merge Tx path functions

[Matan Azrad]

Ok, thanks!

> -----Original Message-----
> From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com]
> Sent: Monday, October 30, 2017 4:24 PM
> To: Matan Azrad <matan at mellanox.com>
> Cc: dev at dpdk.org; Ophir Munk <ophirmu at mellanox.com>
> Subject: Re: [PATCH v3 3/7] net/mlx4: merge Tx path functions
> 
> On Mon, Oct 30, 2017 at 10:07:25AM +0000, Matan Azrad wrote:
> > Merge tx_burst and mlx4_post_send functions to prevent double asking
> > about WQ remain space.
> >
> > Signed-off-by: Matan Azrad <matan at mellanox.com>
> 
> Except for one nit below,
> 
> Acked-by: Adrien Mazarguil <adrien.mazarguil at 6wind.com>
> 
> > ---
> >  drivers/net/mlx4/mlx4_rxtx.c | 357
> > +++++++++++++++++++++----------------------
> >  1 file changed, 172 insertions(+), 185 deletions(-)
> >
> > diff --git a/drivers/net/mlx4/mlx4_rxtx.c
> > b/drivers/net/mlx4/mlx4_rxtx.c
> <snip>
> > @@ -477,18 +314,168 @@ struct pv {
> >  			} while (tmp != NULL);
> >  		}
> >  		RTE_MBUF_PREFETCH_TO_FREE(elt_next->buf);
> > -		/* Post the packet for sending. */
> > -		err = mlx4_post_send(txq, buf);
> > -		if (unlikely(err)) {
> > +
> 
> Extra empty line.
> 
> --
> Adrien Mazarguil
> 6WIND