[dpdk-dev] [PATCH] net/nfp: avoid unplug if multiport

Alejandro Lucero alejandro.lucero at netronome.com
Tue Oct 31 12:04:52 CET 2017


PF multiport support has some limitations like not allowing plugging or
unplugging of single ports as they all belong to same PCI device.

A previous patch for removing detachable flag introduced a wrong check.

Fixes: 00a3d8104ac5 ("ethdev: remove detachable device flag")
Cc: gaetan.rivet at 6wind.com

Signed-off-by: Alejandro Lucero <alejandro.lucero at netronome.com>
---
 drivers/net/nfp/nfp_net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 8c1c1f0..05f26bc 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -3029,7 +3029,7 @@ static int eth_nfp_pci_remove(struct rte_pci_device *pci_dev)
 		hw = NFP_NET_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
 	}
 	/* hotplug is not possible with multiport PF */
-	if (!hw->pf_multiport_enabled)
+	if (hw->pf_multiport_enabled)
 		return -ENOTSUP;
 	return rte_eth_dev_pci_generic_remove(pci_dev, NULL);
 }
-- 
1.9.1



More information about the dev mailing list