[dpdk-dev] [PATCH v4] bus/pci: fix vfio mode

[Thomas Monjalon]

31/10/2017 13:03, Bruce Richardson:
> On Mon, Oct 30, 2017 at 10:32:27PM +0000, Ferruh Yigit wrote:
> > Revert back to using VFIO_PRESENT as a marker to enable compilation
> > of VFIO-related segments.
> > 
> > VFIO_PRESENT is the combination of user configuration RTE_EAL_VFIO and
> > kernel version support check.
> > 
> > eal_vfio.h VFIO_PRESENT related check ordered to be compatible with
> > rte_vfio.h one, no functional modification.
> > 
> > Fixes: 279b581c897d ("vfio: expose functions")
> > 
> > Signed-off-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>
> > Signed-off-by: Gaetan Rivet <gaetan.rivet at 6wind.com>
> > Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> > ---
> > v4:
> > 
> > * Alternative to v3, not superseding it, need to decide which one to
> > get. This one:
> >   * fixes vfio for new kernels
> >   * fixes build for old kernels for vfio enabled in config case
> >   * print warning if vfio enabled in config but not supported by kernel
> > 
> > * Independent from this patch, following may need fixing later
> >   * Kernel version check for vfio is broken for RTE_KERNELDIR
> >   * Kernel VFIO support check can be improved
> > ---
> >  drivers/bus/pci/linux/pci_init.h             |  2 +-
> >  drivers/bus/pci/linux/pci_vfio.c             |  2 +-
> >  lib/librte_eal/common/include/rte_vfio.h     | 14 ++++++++++++++
> >  lib/librte_eal/linuxapp/eal/eal_interrupts.c |  1 -
> >  lib/librte_eal/linuxapp/eal/eal_vfio.h       | 14 ++++++++++----
> >  5 files changed, 26 insertions(+), 7 deletions(-)
> > 
> Hi,
> 
> just to confirm that applying this patch fixes DPDK on my system at
> least.
> 
> From the discussion, I understood that this was a "compilation problem",
> but in practice it manifests itself as compile working ok but your app
> won't work with ports bound to vfio-pci. So please apply some fix for
> this soon.
> 
> Thanks for the work on this, all.
> 
> Tested-by: Bruce Richardson <bruce.richardson at intel.com>

Applied, thanks