[dpdk-dev] [PATCH v2 1/4] ethdev: increase port_id range
Ferruh Yigit
ferruh.yigit at intel.com
Mon Sep 4 11:29:32 CEST 2017
On 9/4/2017 10:06 AM, Bruce Richardson wrote:
> On Mon, Sep 04, 2017 at 01:57:31PM +0800, Zhiyong Yang wrote:
>> Extend port_id definition from uint8_t to uint16_t in lib and drivers
>> data structures, specifically rte_eth_dev_data. Modify the APIs,
>> drivers and app using port_id at the same time except some drivers
>> such as MLX4 and MLX5 due to fail to compile them in my server.
>>
> I think you can change those drivers too - it's not hard to set up
> compilation for MLX drivers (instruction in DPDK docs on the website),
> and even if you can't compile test them, e.g. dpaa2 drivers, or other
> SoC ones, others can do so on your behalf. If you are going to change
> drivers, I think you should change all of them across the board.
+1
>
>> Fix some checkpatch issues from the original code and remove some
>> unnecessary cast operations.
>>
>> Signed-off-by: Zhiyong Yang <zhiyong.yang at intel.com>
>> ---
>> app/pdump/main.c | 2 +-
>> app/test-eventdev/test_perf_common.h | 6 +-
>> app/test-pmd/cmdline.c | 4 +-
>> app/test-pmd/config.c | 4 +-
>> app/test-pmd/testpmd.c | 18 +-
>> app/test-pmd/testpmd.h | 2 +-
>> drivers/event/octeontx/ssovf_evdev.c | 6 +-
>> drivers/event/octeontx/ssovf_evdev.h | 4 +-
>> drivers/event/skeleton/skeleton_eventdev.c | 4 +-
>> drivers/event/skeleton/skeleton_eventdev.h | 2 +-
>> drivers/event/sw/sw_evdev.c | 4 +-
>> drivers/event/sw/sw_evdev.h | 6 +-
>> drivers/event/sw/sw_evdev_xstats.c | 8 +-
>
> These are not ethdev drivers, but eventdev ones. I don't think eventdev
> needs to go to 16-bit port numbers, but there is no harm in doing so.
> However, it would be best to modify eventdev drivers in a separate
> patch - or even patchset.
>
>> drivers/net/af_packet/rte_eth_af_packet.c | 2 +-
>> drivers/net/ark/ark_ethdev.c | 2 +-
>> drivers/net/ark/ark_udm.h | 2 +-
>> drivers/net/avp/avp_ethdev.c | 2 +-
>> drivers/net/bnx2x/bnx2x.c | 11 +-
>> drivers/net/bnx2x/bnx2x_rxtx.h | 4 +-
>> drivers/net/bnx2x/elink.c | 12 +-
>> drivers/net/bnx2x/elink.h | 17 +-
>> drivers/net/bnxt/bnxt.h | 2 +-
>> drivers/net/bnxt/bnxt_ethdev.c | 8 +-
>> drivers/net/bnxt/bnxt_rxq.h | 2 +-
>> drivers/net/bnxt/bnxt_txq.h | 2 +-
>> drivers/net/bnxt/rte_pmd_bnxt.c | 32 +--
>> drivers/net/bnxt/rte_pmd_bnxt.h | 36 ++--
>> drivers/net/bonding/rte_eth_bond.h | 42 ++--
>> drivers/net/bonding/rte_eth_bond_8023ad.c | 6 +-
>> drivers/net/bonding/rte_eth_bond_8023ad_private.h | 6 +-
>> drivers/net/bonding/rte_eth_bond_api.c | 56 ++---
>> drivers/net/bonding/rte_eth_bond_pmd.c | 30 +--
>> drivers/net/bonding/rte_eth_bond_private.h | 43 ++--
>> drivers/net/e1000/em_rxtx.c | 4 +-
>> drivers/net/e1000/igb_rxtx.c | 4 +-
>> drivers/net/failsafe/failsafe_ether.c | 4 +-
>> drivers/net/failsafe/failsafe_private.h | 4 +-
>> drivers/net/fm10k/fm10k.h | 6 +-
>> drivers/net/i40e/i40e_ethdev.c | 5 +-
>> drivers/net/i40e/i40e_rxtx.h | 4 +-
>> drivers/net/i40e/rte_pmd_i40e.c | 50 ++---
>> drivers/net/i40e/rte_pmd_i40e.h | 48 ++---
>> drivers/net/ixgbe/ixgbe_ethdev.c | 5 +-
>> drivers/net/ixgbe/ixgbe_rxtx.h | 4 +-
>> drivers/net/ixgbe/rte_pmd_ixgbe.c | 60 +++---
>> drivers/net/ixgbe/rte_pmd_ixgbe.h | 70 ++++---
>> drivers/net/nfp/nfp_net.c | 26 +--
>> drivers/net/nfp/nfp_net_pmd.h | 2 +-
>> drivers/net/null/rte_eth_null.c | 2 +-
>> drivers/net/pcap/rte_eth_pcap.c | 2 +-
>> drivers/net/qede/qede_if.h | 2 +-
>> drivers/net/ring/rte_eth_ring.c | 2 +-
>> drivers/net/vhost/rte_eth_vhost.c | 8 +-
>> drivers/net/vhost/rte_eth_vhost.h | 6 +-
>> drivers/net/virtio/virtio_pci.h | 2 +-
>> drivers/net/virtio/virtio_rxtx.h | 6 +-
>> drivers/net/xenvirt/virtqueue.h | 2 +-
>> lib/librte_bitratestats/rte_bitrate.c | 2 +-
>> lib/librte_bitratestats/rte_bitrate.h | 2 +-
>> lib/librte_ether/rte_ethdev.c | 239 +++++++++++-----------
>> lib/librte_ether/rte_ethdev.h | 238 ++++++++++-----------
>> lib/librte_ether/rte_tm.c | 62 +++---
>> lib/librte_ether/rte_tm.h | 60 +++---
>> lib/librte_ether/rte_tm_driver.h | 2 +-
>> lib/librte_eventdev/rte_eventdev.c | 36 ++--
>> lib/librte_eventdev/rte_eventdev.h | 34 +--
>> lib/librte_eventdev/rte_eventdev_pmd.h | 8 +-
>
> eventdev changes should be separte patches from ethdev.
What do you think extracting them out of this patcset, and have another
patchset for evendev ones perhaps?
>
>> lib/librte_kni/rte_kni.h | 6 +-
>> lib/librte_latencystats/rte_latencystats.c | 12 +-
>> lib/librte_pdump/rte_pdump.c | 16 +-
>> lib/librte_pdump/rte_pdump.h | 4 +-
>> lib/librte_port/rte_port_ethdev.c | 6 +-
>> lib/librte_port/rte_port_ethdev.h | 6 +-
>> 73 files changed, 733 insertions(+), 715 deletions(-)
>>
More information about the dev
mailing list