[dpdk-dev] [PATCH v2 13/15] devargs: pass busname argument when parsing
ferruh.yigit at intel.com
Mon Sep 4 18:28:54 CEST 2017
On 7/15/2017 3:48 PM, Gaëtan Rivet wrote:
> On Fri, Jul 14, 2017 at 05:12:11PM -0400, Jan Blunck wrote:
>> Let the rte_eal_devargs_parse() function explicitly take a "busname"
>> argument that is validated.
>> Now that the busname is known and validated at parse time the validity of
>> the device name is checked for all device types when they get probed.
> What use is there for a parsing API if the fields have already been
> recognized? Why would someone need to parse an rte_devargs if they already
> know the busname from the devname? This function becomes useless.
rte_eal_devargs_parse() converts devargs_string to the devargs struct,
this usage is still valid.
Getting busname as argument to this function looks good simplification
to me, I didn't get the problem here.
> You are applying here the same logic you used with the rte_dev API,
> where you divided the fields because it made no sense to have them
> However, the rte_dev API is not in contact with users / applications, it
> is not the interface with the outside world where it must take in external
> inputs and format them for subsequent systems to use.
>> Signed-off-by: Jan Blunck <jblunck at infradead.org>
More information about the dev