[dpdk-dev] [PATCH] cmdline: fix warning for unused return value
Stephen Hemminger
stephen at networkplumber.org
Thu Sep 7 19:50:20 CEST 2017
On Thu, 7 Sep 2017 14:09:23 +0100
Bruce Richardson <bruce.richardson at intel.com> wrote:
> When DPDK is compiled on Ubuntu with extra warnings turned on, there is a
> warning about the return value from write() being unchecked. Rather than
> having builds disable the warning, which may mask other cases we do care
> about, we can add a dummy use of the return value in the code to silence it
> in this instance.
>
> Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> ---
> lib/librte_cmdline/cmdline.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_cmdline/cmdline.c b/lib/librte_cmdline/cmdline.c
> index a9c47be..d749165 100644
> --- a/lib/librte_cmdline/cmdline.c
> +++ b/lib/librte_cmdline/cmdline.c
> @@ -205,7 +205,8 @@ cmdline_printf(const struct cmdline *cl, const char *fmt, ...)
> }
> if (ret >= BUFSIZ)
> ret = BUFSIZ - 1;
> - write(cl->s_out, buf, ret);
> + ret = write(cl->s_out, buf, ret);
> + (void)ret;
That is an ugly way to fix the warning.
If write fails, the user has probably logged out.
More information about the dev
mailing list