[dpdk-dev] [PATCH 02/10] net/qede: fix compilation with -Og

[Patil, Harish]

-----Original Message-----
From: dev <dev-bounces at dpdk.org> on behalf of Olivier Matz
<olivier.matz at 6wind.com>
Date: Monday, September 11, 2017 at 8:13 AM
To: "dev at dpdk.org" <dev at dpdk.org>
Subject: [dpdk-dev] [PATCH 02/10] net/qede: fix compilation with -Og

>The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following
>error:
>
>  CC qede_rxtx.o
>  qede_rxtx.c: In function ‘qede_start_queues’:
>  qede_rxtx.c:797:9: error: ‘rc’ may be used uninitialized in this
>                            function [-Werror=maybe-uninitialized]
>    return rc;
>           ^~
>
>If there is no Rx or Tx queue, rc will not be initialized. Fix it
>by initializing rc to -1.
>
>Fixes: 4c4bdadfa9e7 ("net/qede: refactoring multi-queue implementation")
>
>Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>
>---
> drivers/net/qede/qede_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c
>index 5c3613c7c..76e24abff 100644
>--- a/drivers/net/qede/qede_rxtx.c
>+++ b/drivers/net/qede/qede_rxtx.c
>@@ -780,7 +780,7 @@ int qede_start_queues(struct rte_eth_dev *eth_dev)
> {
> 	struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev);
> 	uint8_t id;
>-	int rc;
>+	int rc = -1;
> 
> 	for_each_rss(id) {
> 		rc = qede_rx_queue_start(eth_dev, id);
>-- 
>2.11.0

Acked-by: Harish Patil <harish.patil at cavium.com>

>