[dpdk-dev] [PATCH 1/2] net/sfc: free mbufs in bulks on EF10 native Tx datapath reap

Andrew Rybchenko arybchenko at solarflare.com
Wed Sep 13 08:27:17 CEST 2017


On 09/13/2017 12:51 AM, Stephen Hemminger wrote:
> On Fri, 8 Sep 2017 15:15:50 +0100
> Andrew Rybchenko <arybchenko at solarflare.com> wrote:
>
>> +			txd->mbuf = NULL;
>> +			if (m == NULL)
>> +				continue;
>> +
>> +			if ((nb == RTE_DIM(bulk)) ||
>> +			    ((nb != 0) && (m->pool != bulk[0]->pool))) {
>> +				rte_mempool_put_bulk(bulk[0]->pool,
>> +						     (void *)bulk, nb);
>> +				nb = 0;
>>   			}
>> +
> Why not add rte_mbuf_free_bulk (inline) to base code, rather than recoding
> everywhere?

I'm not 100% sure that I understand the question in a right way, but if 
you're
talking about base driver code, it is not used in native datapath 
implementations
at all (just header files with HW/SW interface definition). In fact 
patches 1 and 2
of the series are slightly different and the difference is proved by 
performance
measurements.


More information about the dev mailing list