[dpdk-dev] [PATCH v3 1/2] ethdev: introduce Rx queue offloads API
Shahaf Shuler
shahafs at mellanox.com
Wed Sep 13 14:33:02 CEST 2017
Wednesday, September 13, 2017 12:13 PM, Andrew Rybchenko:
>>return -EBUSY;
>> }
>> + /*
>>+ * Convert between the offloads API to enable PMDs to support
>>+ * only one of them.
>>+ */
>>+ if ((dev_conf->rxmode.ignore_offload_bitfield == 0)) {
>>+ rte_eth_convert_rx_offload_bitfield(
>>+ &dev_conf->rxmode, &local_conf.rxmode.offloads);
>>+ } else {
>>+ rte_eth_convert_rx_offloads(dev_conf->rxmode.offloads,
>>+ &local_conf.rxmode);
>Ignore flag is lost here and it will result in treating txq_flags as the primary
>information about offloads. It is important in the case of failsafe PMD.
>
>Sorry, I mean rxmode (not txq_flags).
Am not sure the ignore_offload_bitfield is lost on converstion. The convert function does not assign to it.
More information about the dev
mailing list