[dpdk-dev] [PATCH v3 2/4] eventdev: Add eth Rx adapter caps callback to SW evdev

[Rao, Nikhil]

On 9/13/2017 7:06 PM, Nipun Gupta wrote:
> 
> 
>> -----Original Message-----
>> From: Nikhil Rao [mailto:nikhil.rao at intel.com]
>> ---
>>   lib/librte_eventdev/rte_eventdev_pmd.h |  6 ++++++
>>   drivers/event/sw/sw_evdev.c            | 13 +++++++++++++
>>   2 files changed, 19 insertions(+)
>>
>> diff --git a/lib/librte_eventdev/rte_eventdev_pmd.h
>> b/lib/librte_eventdev/rte_eventdev_pmd.h
>> index 4cc9671..3cbc063 100644
>> --- a/lib/librte_eventdev/rte_eventdev_pmd.h
>> +++ b/lib/librte_eventdev/rte_eventdev_pmd.h
>> @@ -83,6 +83,12 @@ extern "C" {
>>   	} \
>>   } while (0)
>>
>> +#define RTE_EVENT_ETH_RX_ADAPTER_SW_CAP \
>> +		RTE_EVENT_ETH_RX_ADAPTER_CAP_FLOW_ID
>> +/**< Ethernet Rx adapter cap to return If the packet transfers from
>> + * the ethdev to eventdev use a SW service function
>> + */
> 
> Hi Nikhil,
> 
> Maybe it makes more sense to have RTE_EVENT_ETH_RX_ADAPTER_SW_CAP #define in 'sw_evdev.h' file?
> 
The usage of this #define is not intended to be restricted to sw_evdev.c.

Eventdev PMDs may need to use the SW implementation of ethdev to 
eventdev packet transfer for some eth ports (e.g., veth) while they may 
support a HW transfer mechanism for SoC eth ports, in that case the 
eventdev PMD would need access to this define. Hope that answers your 
question.

Thanks,
Nikhil