[dpdk-dev] [PATCH v2 05/30] bus/fslmc: enhance the QBMAN CENA mode

Ferruh Yigit ferruh.yigit at intel.com
Fri Sep 15 14:26:34 CEST 2017


On 9/8/2017 9:45 AM, Hemant Agrawal wrote:
> From: Haiying Wang <Haiying.Wang at nxp.com>
> 
> Signed-off-by: Haiying Wang <Haiying.Wang at nxp.com>
> Signed-off-by: Hemant Agrawal <hemant.agrawal at nxp.com>
> ---
>  drivers/bus/fslmc/qbman/qbman_sys.h | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/bus/fslmc/qbman/qbman_sys.h b/drivers/bus/fslmc/qbman/qbman_sys.h
> index 9ea55de..47da595 100644
> --- a/drivers/bus/fslmc/qbman/qbman_sys.h
> +++ b/drivers/bus/fslmc/qbman/qbman_sys.h
> @@ -217,7 +217,6 @@ static inline void qbman_cena_write_complete_wo_shadow(struct qbman_swp_sys *s,
>  #ifdef QBMAN_CENA_TRACE
>  	pr_info("qbman_cena_write_complete(%p:%d:0x%03x)\n",
>  		s->addr_cena, s->idx, offset);
> -	hexdump(cmd, 64);
>  #endif
>  	dcbf(s->addr_cena + offset);
>  }
> @@ -251,11 +250,7 @@ static inline void *qbman_cena_read_wo_shadow(struct qbman_swp_sys *s,
>  {
>  #ifdef QBMAN_CENA_TRACE
>  	pr_info("qbman_cena_read(%p:%d:0x%03x) %p\n",
> -		s->addr_cena, s->idx, offset, shadow);
> -#endif
> -
> -#ifdef QBMAN_CENA_TRACE
> -	hexdump(shadow, 64);
> +		s->addr_cena, s->idx, offset);

Isn't this missing one parameter, previous "shadow" one?

>  #endif
>  	return s->addr_cena + offset;
>  }
> 



More information about the dev mailing list