[dpdk-dev] [PATCH] crypto/ccp: Add support for AMD CCP Crypto poll mode driver

[Kumar, Ravi1]

>> -----Original Message-----
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Kumar, Ravi1
>> Sent: Wednesday, August 30, 2017 7:25 AM
>> To: dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] crypto/ccp: Add support for AMD CCP 
>> Crypto poll mode driver
>> 
>> Hi,
>> 
>> Please do not consider this patch as the license has to be updated. We 
>> are working with our legal team to get that done.
>
>Hi Ravi,
>
>I have several comments about this patch, for the v2 that you will send:
>
>- Could you split the patch into separate patches? The patch is quite big to be reviewed easily.
>  Here it is an example of how you should do it:
>  http://dpdk.org/ml/archives/dev/2017-April/064385.html
>
>- When including a file that is in the same folder, use quotes:
>  #include <ccp_crypto.h> --> #include "ccp_crypto.h".
>
>- There are some checkpatch errors. Look at patchwork:
>  http://dpdk.org/ml/archives/test-report/2017-August/027829.html
>
>- I think you should add some tests for this PMD. You don't really need to add  new tests, you can just add a test suite for this driver and use the existing tests.
>
>Last thing, when replying to a patch, comment inline and use ">" before each line, otherwise patchwork picks up the email as a new patch.

Hi Pablo,

Thanks a lot for the review comments. We have been working on this and will send updated patches once we are ready. 

Regards,
Ravi

>
>Thanks!
>Pablo