[dpdk-dev] [PATCH v5] net/mlx5: support upstream rdma-core

Ferruh Yigit ferruh.yigit at intel.com
Mon Sep 18 11:07:16 CEST 2017


On 9/17/2017 8:31 AM, Shachar Beiser wrote:
> 
> 
>> -----Original Message-----
>> From: Ferruh Yigit [mailto:ferruh.yigit at intel.com]
>> Sent: Thursday, September 14, 2017 4:47 PM
>> To: Shachar Beiser <shacharbe at mellanox.com>; dev at dpdk.org
>> Cc: Adrien Mazarguil <adrien.mazarguil at 6wind.com>; Nélio Laranjeiro
>> <nelio.laranjeiro at 6wind.com>
>> Subject: Re: [dpdk-dev] [PATCH v5] net/mlx5: support upstream rdma-core
>>
>> On 9/14/2017 2:34 PM, Shachar Beiser wrote:
>>> This removes the dependency on specific Mellanox OFED libraries by
>>> using the upstream rdma-core and linux upstream community code.
>>
>> Would you mind mentioning what is the difference between "specific
>> Mellanox OFED libraries" and "upstream rdma-core"? If not in the
>> documentation, at least in mail list for interested people?
>>
>> Does it make sense to put this update into release notes?
>>
>> Thanks,
>> ferruh
>>
> 
>  Hi Ferruh,
> 
> Both packages, rdma-core upstream &  Mellanox OFED are Linux user-space packages :
>  	1. Rdma-core is the Linux upstream user-space package.
>  	2. Mellanox OFED  is the Mellanox's Linux user-space package.
>  The difference is the APIs . We shall explain that difference in the 
>  release notes .

The difference can be too much detail for release notes, I believe it is
good to mention in release notes the dependency requirement change, as
above commit log.

But this commit log can have the detail.

>  
>              -Shachar Beiser.
> 
>>>
>>> ---
>>> I have squashed :
>>> [PATCH v2 3/3] “net/mlx5: fix interrupt enable return”
>>>
>> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpd
>> k
>>>
>> .org%2Fdev%2Fpatchwork%2Fpatch%2F28380%2F&data=02%7C01%7Cshach
>> arbe%40m
>>>
>> ellanox.com%7Cc79d7690cb454f8dd41508d4fb771dea%7Ca652971c7d2e4d9b
>> a6a4d
>>>
>> 149256f461b%7C0%7C0%7C636409936407431479&sdata=T5wgSUeCx1tzM9Z
>> UnBAauNt
>>> iG4djfIpOJZOj%2FWM6v4Y%3D&reserved=0
>>> into this patch
>>>
>>> a. Compile with rdma-core commit f11292efd541 ("Merge pull request
>>> #202") b. Tested with linux kernel 4.13-rc4 c. For performance testing
>>> recommended to wait till kernel 4.14
>>>
>>> Signed-off-by: Shachar Beiser <shacharbe at mellanox.com>
>>
>> <...>
> 



More information about the dev mailing list