[dpdk-dev] [PATCH v2 1/3] crypto/aesni_mb: add DES support
De Lara Guarch, Pablo
pablo.de.lara.guarch at intel.com
Mon Sep 18 16:08:00 CEST 2017
> -----Original Message-----
> From: Nicolau, Radu
> Sent: Monday, September 18, 2017 11:56 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; Doherty,
> Declan <declan.doherty at intel.com>
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/3] crypto/aesni_mb: add DES support
>
>
>
> On 9/15/2017 3:09 AM, Pablo de Lara wrote:
> > The Multi-buffer library now supports DES-CBC and DES-DOCSISBPI
> > algorithms, so this commit extends adds support for them in the PMD.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>
> > Acked-by: Fan Zhang <roy.fan.zhang at intel.com>
> > ---
> > doc/guides/cryptodevs/aesni_mb.rst | 2 +
> > doc/guides/cryptodevs/features/aesni_mb.ini | 3 ++
> > doc/guides/rel_notes/release_17_11.rst | 7 +++
> > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 74
> ++++++++++++++++++--------
> > drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 42
> +++++++++++++++
> > test/test/test_cryptodev.c | 42 +++++++++++++++
> > test/test/test_cryptodev_des_test_vectors.h | 24 ++++++---
> > 7 files changed, 163 insertions(+), 31 deletions(-)
> >
> > <snip>
> >
> > +#include <des.h>
> > +
> > #include <rte_common.h>
> > #include <rte_hexdump.h>
> > #include <rte_cryptodev.h>
> > @@ -188,6 +190,7 @@ aesni_mb_set_session_cipher_parameters(const
> struct aesni_mb_op_fns *mb_ops,
> > struct aesni_mb_session *sess,
> > const struct rte_crypto_sym_xform *xform)
> > {
> > + uint8_t is_aes;
> Nitpicking: Maybe initialize with zero and remove is_aes = 0; from the
> switch body?
Good idea. Will do and will send a v3.
Thanks!
Pablo
> Reviewed-by: Radu Nicolau <radu.nicolau at intel.com>
More information about the dev
mailing list