[dpdk-dev] [PATCH v2] sched: make RED scaling configurable

[Kantecki, Tomasz]

> -----Original Message-----
> From: alangordondewar at gmail.com [mailto:alangordondewar at gmail.com] 
> Sent: Wednesday, September 13, 2017 11:16 AM
> To: Kantecki, Tomasz <tomasz.kantecki at intel.com>
> Cc: dev at dpdk.org; Alan Dewar <alan.dewar at att.com>
> Subject: [PATCH v2] sched: make RED scaling configurable
>
> From: Alan Dewar <alan.dewar at att.com>
>
> The RED code stores the maximum threshold is a 32-bit integer as a
> pseudo fixed-point floating number with 10 fractional bits.  Twelve
> other bits are used to encode the filter weight, leaving just 10 bits
> for the queue length.  This limits the maximum queue length supported
> by RED queues as 1024 packets.
>
> Move the "hard" definitions from red.h into config/common_base so that
> RED scaling can be configured during build.
>
> Modified the RED unit-tests to use the new "soft" definition of
> maximum-threshold from config/common_base in tests where it previously
> used a hard coded limit of 1023.
>
> The RED unit-tests all successfully pass when the maximum-threshold is
> configured as 8191 and the RED scaling factor is dropped to seven.
>
> Real-world testing has involved RED queue lengths of 8192 with multiple
> different settings of the RED config parameters: min_th, max_th, wq_log2
> and maxp_inv.
>
> Signed-off-by: Alan Dewar <alan.dewar at att.com>
> ---

Thanks! The patch looks good to me.
The only thing that potentially could be added is a brief description of the parameters in the common_base file.

Acked-by: Tomasz Kantecki <tomasz.kantecki at intel.com>

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.