[dpdk-dev] [PATCH v4 04/41] bus/dpaa: add OF parser for device scanning

[Ferruh Yigit]

On 9/19/2017 2:37 PM, Shreyansh Jain wrote:
> On Monday 18 September 2017 08:19 PM, Ferruh Yigit wrote:
>> On 9/9/2017 12:20 PM, Shreyansh Jain wrote:
>>> This layer is used by Bus driver's scan function. Devices are parsed
>>> using OF parser and added to DPAA device list.
>>
>> So this is device tree parser in DPDK. Do we really want this, and as
>> long as DPDK target the bare metal why not get device information from
>> Linux, as done in other cases?
> As of now I don't prefer to modify the internal framework as much as 
> possible as this is stable DPDK DPAA driver.
> There is indeed a planned transition from OF to /sys/ parsing, but it is 
> still in pipeline.
> 
> You see a blocking issue if we go incremental here?
> That would be probably more of replacing this file with another /sys 
> parser without much changes to the DPDK glue code.

OF parser in DPDK looks weird to me, OS will do this for us already.

If replacing this is in the roadmap, I think this is not showstopper,
added Thomas in case he thinks otherwise.

> 
>>
>>>
>>> Signed-off-by: Geoff Thorpe <geoff.thorpe at nxp.com>
>>> Signed-off-by: Shreyansh Jain <shreyansh.jain at nxp.com>
>>> ---
>>>   drivers/bus/dpaa/Makefile       |   7 +
>>>   drivers/bus/dpaa/base/fman/of.c | 576 ++++++++++++++++++++++++++++++++++++++++
>>>   drivers/bus/dpaa/include/of.h   | 190 +++++++++++++
>>>   3 files changed, 773 insertions(+)
>>>   create mode 100644 drivers/bus/dpaa/base/fman/of.c
>>>   create mode 100644 drivers/bus/dpaa/include/of.h
>>>
>>
>> <...>
>>
>>
>