[dpdk-dev] [PATCH v3 21/40] maintainers: claim ownership of DPAA Mempool driver

Shreyansh Jain shreyansh.jain at nxp.com
Wed Sep 27 10:30:19 CEST 2017


On Friday 22 September 2017 01:05 PM, Thomas Monjalon wrote:
> 22/09/2017 09:37, Shreyansh Jain:
>> On Friday 22 September 2017 12:23 PM, Thomas Monjalon wrote:
>>> 22/09/2017 08:47, Shreyansh Jain:
>>>> On Friday 22 September 2017 03:26 AM, Thomas Monjalon wrote:
>>>>> 23/08/2017 16:11, Shreyansh Jain:
>>>>>> --- a/MAINTAINERS
>>>>>> +++ b/MAINTAINERS
>>>>>> @@ -409,6 +409,7 @@ NXP dpaa
>>>>>>     M: Hemant Agrawal <hemant.agrawal at nxp.com>
>>>>>>     M: Shreyansh Jain <shreyansh.jain at nxp.com>
>>>>>>     F: drivers/bus/dpaa/
>>>>>> +F: drivers/mempool/dpaa/
>>>>>>     F: doc/guides/nics/dpaa.rst
>>>>>>     F: doc/guides/nics/features/dpaa.ini
>>>>>
>>>>> This kind of patch can be squashed in the first patch introducing
>>>>> this new directory.
>>>>
>>>> Then the patch script (devtools/check-git-log.sh) reports error - I
>>>> think. That is the primary reason I split them across multiple patches.
>>>> You sure that doesn't matter?
>>>
>>> Which error?
>>>
>>> To be clear I suggest to squash with patch 19 where
>>> drivers/mempool/dpaa/Makefile is introduced.
>>
>> Yes, I understand that.
>> It would report error that the headline is wrong because I am hitting
>> different directories - "MAINTAINERS" and "drivers/mempool/*" with the
>> same patch having headline "mempool/*".
> 
> The test you are talking about has this comment:
> 	# check headline prefix when touching only drivers, e.g. net/<driver name>
> If you hit a warning, there is a bug.

Somehow I had the impression it throws an error in such cases. I changed 
as suggested and check-git-log.sh script didn't throw any error - I was 
wrong. Thanks for correcting.

-
Shreyansh



More information about the dev mailing list