[dpdk-dev] [PATCH v4 02/41] bus/dpaa: introduce NXP DPAA Bus driver skeleton

[Shreyansh Jain]

On Monday 25 September 2017 08:41 PM, Ferruh Yigit wrote:
> On 9/25/2017 3:32 PM, Shreyansh Jain wrote:
>> On Tuesday 19 September 2017 06:44 PM, Shreyansh Jain wrote:
>>> Hello Ferruh,
>>>
>>> On Monday 18 September 2017 08:17 PM, Ferruh Yigit wrote:
>>>> On 9/9/2017 12:20 PM, Shreyansh Jain wrote:
>>>>> Signed-off-by: Shreyansh Jain <shreyansh.jain at nxp.com>
>>>>> Signed-off-by: Hemant Agrawal <hemant.agrawal at nxp.com>
>>>>
>>>> <...>
>>>>
>>>>> diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map
>>>>> b/drivers/bus/dpaa/rte_bus_dpaa_version.map
>>>>> new file mode 100644
>>>>> index 0000000..d97a009
>>>>> --- /dev/null
>>>>> +++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map
>>>>> @@ -0,0 +1,7 @@
>>>>> +DPDK_17.11 {
>>>>> +    global:
>>>>> +
>>>>> +    rte_dpaa_driver_register;
>>>>> +    rte_dpaa_driver_unregister;
>>>>
>>>> "local *;" ?
>>>
>>> Agree. I will change this.
>>> Currently rte_dpaa_driver_* functions are being used locally within
>>> bus/dpaa.
>>>
>>
>> Even though I agree earlier that I will change this (append 'local *:'
>> to the file), probably I will have to skip this.
>> Further in the patch series, there are some symbols which are added
>> which are required by the mempool and net drivers (and crypto, in
>> future). Shared compilation fails for them if I add 'local: *;' here.
> 
> It should be OK if this is last item in the first group.
> 
> Technically I believe it will be OK to remove that line, but not quite sure.
> 
> Lets be consistent with exiting usage and keep it, there are many sample
> map files.
> 

I had a look at the various map files in code. There is a mixed usage.
Most don't have 'local' tag in their last blocks which exposes symbols. 
Some, like octeonx, bnxt have both.

I am not very sure of how this changes the scope of variables. So, as of 
now I have made DPAA to have both - global and local in its 17.11 symbol 
block.