[dpdk-dev] [PATCH v6 8/8] mempool: notify memory area to pool

Olivier MATZ olivier.matz at 6wind.com
Fri Sep 29 10:20:50 CEST 2017


On Fri, Sep 29, 2017 at 05:53:43AM +0100, santosh wrote:
> Hi Olivier,
> 
> 
> On Monday 25 September 2017 11:18 PM, santosh wrote:
> > On Monday 25 September 2017 12:41 PM, Olivier MATZ wrote:
> >> On Thu, Sep 07, 2017 at 09:00:42PM +0530, Santosh Shukla wrote:
> >>> + * Mempool handler usually get notified once for the case of mempool get full
> >>> + * range of memory area. However, if several memory areas exist then mempool
> >>> + * handler gets notified each time.
> >> Not sure I understand this last paragraph.
> > Refer v5 history [1] for same.
> >
> > [1] http://dpdk.org/dev/patchwork/patch/28419/
> >
> > there will be a case where mempool handler may have more than one memory example, no-hugepage case.
> > In that case _register_memory_area() ops will be called for more than once.
> >
> > In v5, you suggested to mention this case explicitly in api description.
> >
> > If your not clear with write up then could you propose one and also are you fine
> > with [8/8] patch beside above note? planning to send v7 by tomorrow, appreciate if you answer question.
> 
> Ping?
> 
> IMO, remove above description keep it like:
> "API to notify the mempool handler if a new memory area is added to pool." Is it ok with you? Can you pl. confirm, I need to send v7 and we want this series in -rc1, its blocking octeontx mempool and nw driver.. delayed review blocking progress.

The proposed description is ok.
I have no other comment for the rest of the patch.



More information about the dev mailing list