[dpdk-dev] [PATCH] checkpatch: re-enable warnings about split long strings
Stephen Hemminger
stephen at networkplumber.org
Fri Sep 29 17:37:49 CEST 2017
The Linux kernel style policy about strings is that strings should
be always put on one line. This makes sense since a typical use
case is for a user to type the error message into a search engine
or grep, and it won't be found if split across lines.
This patch just re-enables that check.
Yes, lots of DPDK code now splits strings, that doesn't
make it right.
Signed-off-by: Stephen Hemminger <sthemmin at microsoft.com>
---
devtools/checkpatches.sh | 1 -
1 file changed, 1 deletion(-)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index a56c41a301c0..3e6081dd673e 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -44,7 +44,6 @@ options="$options --show-types"
options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\
VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\
-SPLIT_STRING,LONG_LINE_STRING,\
LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
NEW_TYPEDEFS,COMPARISON_TO_NULL"
--
2.11.0
More information about the dev
mailing list