[dpdk-dev] [PATCH] net/tap: fix memcpy with incorrect size

Ferruh Yigit ferruh.yigit at intel.com
Fri Apr 6 17:02:31 CEST 2018


On 4/6/2018 12:50 PM, Yang, Zhiyong wrote:
> 
>> -----Original Message-----
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pavan Nikhilesh
>> Sent: Friday, April 6, 2018 7:31 PM
>> To: jerin.jacob at caviumnetworks.com; Yigit, Ferruh <ferruh.yigit at intel.com>;
>> pascal.mazon at 6wind.com; Varghese, Vipin <vipin.varghese at intel.com>;
>> thomas at monjalon.net
>> Cc: dev at dpdk.org; Pavan Nikhilesh <pbhagavatula at caviumnetworks.com>
>> Subject: [dpdk-dev] [PATCH] net/tap: fix memcpy with incorrect size
>>
>> Fix incorrect sizeof operation being used for getting mac addr size.
>>
>> Found while compiling with arm64 clang.
>> drivers/net/tap/rte_eth_tap.c:1410:40: error: argument to 'sizeof' in
>>     'memcpy' call is the same pointer type 'struct ether_addr *' as the
>>     destination; expected 'struct ether_addr' or an explicit length
>>     [-Werror,-Wsizeof-pointer-memaccess]
>>        rte_memcpy(&pmd->eth_addr, mac_addr, sizeof(mac_addr));
>>                   ~~~~~~~~~~~~~~            ^~~~~~~~~~~~~~~~
>>
>> Fixes: bcab6c1d27fa ("net/tap: allow user MAC to be passed as args")
>>
>> Signed-off-by: Pavan Nikhilesh <pbhagavatula at caviumnetworks.com>

> Acked-by: Zhiyong Yang <zhiyong.yang at intel.com>

Applied to dpdk-next-net/master, thanks.


More information about the dev mailing list