[dpdk-dev] [PATCH v5 4/4] testpmd: make use of per-PMD TxRx parameters

[Remy Horton]

On 09/04/2018 13:55, Shreyansh Jain wrote:
[..]
> Documentation for burst mode changes to testpmd would need an update.
> I guess, only when the user explicitly sets 'set burst 0' would the
> driver defaults be picked up - isn't it?

Yes.


> Maybe something like this:
>
> --->8---
> --- a/doc/guides/testpmd_app_ug/run_app.rst
> +++ b/doc/guides/testpmd_app_ug/run_app.rst
> @@ -372,7 +372,9 @@ The commandline options are:
>  *   ``--burst=N``
>
>      Set the number of packets per burst to N, where 1 <= N <= 512.
> -    The default value is 16.
> +    The default value is 32.
> +    If set to 0, driver default is used if defined. Else, if driver
> default
> +    is not defined, default of 32 is used.
>
>  *   ``--mbcache=N``
> --->8---
>
> In the above, I think the existing documented default value needs to be
> changed. It is set to '#define DEF_PKT_BURST 32'

Had a quick look and it looks like that discrepancy has been there since 
the documentation was converted to .rst in 2014.


> If you add that, please use my ack for next revision.
> (For patch 1/4, I had already given my Ack in v2)

I'll add in the snippet above. 18.05 integration deadline has I think 
passed, but documentation changes will still get in.