[dpdk-dev] [RFC 0/2] nfp driver fixes
Alejandro Lucero
alejandro.lucero at netronome.com
Fri Apr 13 17:36:25 CEST 2018
On Fri, Apr 13, 2018 at 2:23 PM, Aaron Conole <aconole at redhat.com> wrote:
> Alejandro Lucero <alejandro.lucero at netronome.com> writes:
>
> > Hi Aaron,
> >
> > Thanks for this patches.
> >
> > I'm afraid these are not applicable for current NFP driver after commit
>
> Okay.
>
> > "net/nfp: add NFP CPP support"
> >
> > which has been accepted in dpdk-net-next.
>
> I think nfp_acquire_process_lock() can be modified as I did in 2/2, but
> I noticed that there's some reliance on various sysfs files (and I think
> you point this out in your response to 2/2 as well) and that may be
> problematic for us with ovs2.8+. I'll do some more digging.
>
If OVS always relies on VFIO, then it is fine and this patch makes sense.
>
> Thanks Alejandro!
>
> > However, those could be valid for stable versions. I have comments on
> both patches.
>
> Cool. As I noted, I haven't tested them yet, but once I get time to
> test them I will pull in any feedback and resubmit. I guess if I do,
> they should really just be for stable fixes? Not sure how that would
> work.
>
>
Not sure how this needs to be done. Stable versions pull from main branch
just for bug fixing applied patches.
Maybe it is worth to discuss. Adding stable email.
> > On Fri, Apr 13, 2018 at 12:22 AM, Aaron Conole <aconole at redhat.com>
> wrote:
> >
> > Two fixes, one which is fairly obvious (1/2), the other which may
> > allow support of non-root users. These patches are only compile tested
> > which is why they are submitted as RFC. After a proper test, will
> > resubmit them as PATCH (with any suggested / recommended changes).
> >
> > Aaron Conole (2):
> > nfp: unlink the appropriate lock file
> > nfp: allow for non-root user
> >
> > drivers/net/nfp/nfp_nfpu.c | 25 +++++++++++++++++++++----
> > 1 file changed, 21 insertions(+), 4 deletions(-)
> >
> > --
> > 2.14.3
>
More information about the dev
mailing list