[dpdk-dev] [PATCH v3] net/ixgbe: Add access and locking APIs for MDIO

Shweta Choudaha shweta.choudaha at gmail.com
Fri Apr 13 18:41:14 CEST 2018


Hi Qi,

   I have addressed your comments and sent a v4 patchset.

Thanks,
Shweta

On Fri, Apr 13, 2018 at 3:37 AM, Zhang, Qi Z <qi.z.zhang at intel.com> wrote:

> Hi Choudaha:
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Shweta Choudaha
> > Sent: Wednesday, April 11, 2018 10:00 PM
> > To: dev at dpdk.org
> > Cc: Lu, Wenzhuo <wenzhuo.lu at intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev at intel.com>; Zhang, Helin <helin.zhang at intel.com>;
> Yigit,
> > Ferruh <ferruh.yigit at intel.com>; shweta.choudaha at att.com
> > Subject: [dpdk-dev] [PATCH v3] net/ixgbe: Add access and locking APIs for
> > MDIO
>
> Nitpick: title should not start with uppercase.
>
> > +
> > +EXPERIMENTAL {
> > +     global:
> > +
> > +     rte_pmd_ixgbe_lock_mdio;
> > +     rte_pmd_ixgbe_unlock_mdio;
>
> Can we rename to rte_pmd_ixgbe_mdio_lock and rte_pmd_ixgbe_mdio_unlock, so
> all mdio functions can be list closely when follow the alphabet sequence?
>
>
> > +     rte_pmd_ixgbe_mdio_read_unlocked;
> > +     rte_pmd_ixgbe_mdio_write_unlocked;
>
> And this could be rte_pmd_ixgbe_mdio_unlocked_read/write to follow the
> same pattern that action after object
>
> Regards
> Qi
>
> > +} DPDK_18.05;
> > --
> > 2.11.0
>
>


More information about the dev mailing list