[dpdk-dev] [PATCH] baseband/turbo_sw: offload cost measurement test

Mokhtar, Amr amr.mokhtar at intel.com
Sat Apr 14 01:37:40 CEST 2018



> -----Original Message-----
> From: Chalupnik, KamilX
> Sent: Wednesday 4 April 2018 15:06
> To: dev at dpdk.org
> Cc: Mokhtar, Amr <amr.mokhtar at intel.com>; Chalupnik, KamilX
> <kamilx.chalupnik at intel.com>
> Subject: [PATCH] baseband/turbo_sw: offload cost measurement test
> 
> From: "Chalupnik, KamilX" <kamilx.chalupnik at intel.com>
> 
> New test created to measure offload cost.
> Changes were introduced in API, turbo software driver
> and test application
> 
> Signed-off-by: KamilX Chalupnik <kamilx.chalupnik at intel.com>



> b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> index 302abf5..70691f3 100644
> --- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> +++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> @@ -9,6 +9,7 @@
>  #include <rte_malloc.h>
>  #include <rte_ring.h>
>  #include <rte_kvargs.h>
> +#include <rte_cycles.h>
> 
>  #include <rte_bbdev.h>
>  #include <rte_bbdev_pmd.h>
> @@ -20,18 +21,6 @@
> 
>  #define DRIVER_NAME turbo_sw
> 
> -/* Turbo SW PMD logging ID */
> -static int bbdev_turbo_sw_logtype;
> -
> -/* Helper macro for logging */
> -#define rte_bbdev_log(level, fmt, ...) \
> -	rte_log(RTE_LOG_ ## level, bbdev_turbo_sw_logtype, fmt "\n", \
> -		##__VA_ARGS__)
> -
> -#define rte_bbdev_log_debug(fmt, ...) \
> -	rte_bbdev_log(DEBUG, RTE_STR(__LINE__) ":%s() " fmt, __func__, \
> -		##__VA_ARGS__)
> -

Why deleting logging macros?
This prevents turbo_sw driver from building. 
Please ignore my previous Ack, it was set to this patch wrongly..

Thanks,
Amr


More information about the dev mailing list