[dpdk-dev] [PATCH v9 09/11] crypto/virtio: build with meson

[Zhoujian (jay)]

Hi Pablo,

> -----Original Message-----
> From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch at intel.com]
> Sent: Sunday, April 15, 2018 8:09 PM
> To: Zhoujian (jay) <jianjay.zhou at huawei.com>; dev at dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang at intel.com>; thomas at monjalon.net; Gonglei
> (Arei) <arei.gonglei at huawei.com>; Zeng, Xin <xin.zeng at intel.com>;
> Huangweidong (C) <weidong.huang at huawei.com>; wangxin (U)
> <wangxinxin.wang at huawei.com>; longpeng <longpeng2 at huawei.com>
> Subject: RE: [PATCH v9 09/11] crypto/virtio: build with meson
> 
> Hi Jay,
> 
> > -----Original Message-----
> > From: Jay Zhou [mailto:jianjay.zhou at huawei.com]
> > Sent: Sunday, April 15, 2018 9:51 AM
> > To: dev at dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; Zhang, Roy
> > Fan <roy.fan.zhang at intel.com>; thomas at monjalon.net;
> > arei.gonglei at huawei.com; Zeng, Xin <xin.zeng at intel.com>;
> > weidong.huang at huawei.com; wangxinxin.wang at huawei.com;
> > longpeng2 at huawei.com; jianjay.zhou at huawei.com
> > Subject: [PATCH v9 09/11] crypto/virtio: build with meson
> >
> > Signed-off-by: Jay Zhou <jianjay.zhou at huawei.com>
> > Reviewed-by: Fan Zhang <roy.fan.zhang at intel.com>
> > Acked-by: Fan Zhang <roy.fan.zhang at intel.com>
> > ---
> >  drivers/crypto/meson.build        |  2 +-
> >  drivers/crypto/virtio/meson.build | 12 ++++++++++++
> >  2 files changed, 13 insertions(+), 1 deletion(-)  create mode 100644
> > drivers/crypto/virtio/meson.build
> >
> > diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build
> > index
> > 736c9f5..63649c9 100644
> > --- a/drivers/crypto/meson.build
> > +++ b/drivers/crypto/meson.build
> > @@ -2,7 +2,7 @@
> >  # Copyright(c) 2017 Intel Corporation
> >
> >  drivers = ['dpaa_sec', 'dpaa2_sec',
> > -	'openssl', 'null', 'qat']
> > +	'openssl', 'null', 'qat', 'virtio']
> >
> >  std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps
> > config_flag_fmt = 'RTE_LIBRTE_ at 0@_PMD'
> > diff --git a/drivers/crypto/virtio/meson.build
> > b/drivers/crypto/virtio/meson.build
> > new file mode 100644
> > index 0000000..cee77cc
> > --- /dev/null
> > +++ b/drivers/crypto/virtio/meson.build
> > @@ -0,0 +1,12 @@
> > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 HUAWEI
> > +TECHNOLOGIES CO., LTD.
> > +
> > +dep = dependency('libcrypto', required: false) if not dep.found()
> > +	build = false
> > +endif
> > +deps += ['bus_pci']
> > +sources = files('virtio_cryptodev.c', 'virtio_pci.c',
> > +		'virtio_rxtx.c', 'virtqueue.c')
> > +ext_deps += dep
> > +pkgconfig_extra_libs += '-lcrypto'
> > --
> > 1.8.3.1
> >
> 
> Could you add this build from the first patch? Basically, every time you make
> a change in the Makefile, you should do the same in meson.build.

I'll split this patch into two parts and squash them into the first and the second
patch. Thanks for your suggestion.

Regards,
Jay

> 
> Thanks,
> Pablo