[dpdk-dev] [PATCH v3 04/14] net/mlx5: support Rx tunnel type identification

[Nélio Laranjeiro]

On Sat, Apr 14, 2018 at 12:57:58PM +0000, Xueming(Steven) Li wrote:
> +Adrien
> 
> > -----Original Message-----
> > From: Nélio Laranjeiro <nelio.laranjeiro at 6wind.com>
> > Sent: Friday, April 13, 2018 9:03 PM
> > To: Xueming(Steven) Li <xuemingl at mellanox.com>
> > Cc: Shahaf Shuler <shahafs at mellanox.com>; dev at dpdk.org; Olivier Matz
> > <olivier.matz at 6wind.com>
> > Subject: Re: [PATCH v3 04/14] net/mlx5: support Rx tunnel type
> > identification
> > 
> > +Olivier,
> > 
> > On Fri, Apr 13, 2018 at 07:20:13PM +0800, Xueming Li wrote:
> > > This patch introduced tunnel type identification based on flow rules.
> > > If flows of multiple tunnel types built on same queue,
> > > RTE_PTYPE_TUNNEL_MASK will be returned, user application could use
> > > bits in flow mark as tunnel type identifier.
> > 
> > For an application it will mean the packet embed all tunnel types defined
> > in DPDK, to make such thing you need a RTE_PTYPE_TUNNEL_UNKNOWN which does
> > not exists currently.
> 
> There was a RTE_PTYPE_TUNNEL_UNKNOWN definition, but removed due to discussion.
> So I think it good to add it in the patchset of reviewed by Adrien.

Agreed,

> 
> > Even with it, the application still needs to parse the packet to discover
> > which tunnel the packet embed, is there any benefit having such bit?  Not
> > so sure.
> 
> With a tunnel flag, checksum status represent inner checksum.

Not sure this is generic enough, MLX5 behaves as this, but how behaves
other NICs?  It should have specific bits for inner checksum if all NIC
don't have the same behavior.

> Setting flow mark for different flow type could save time of parsing tunnel.

Thanks,

-- 
Nélio Laranjeiro
6WIND