[dpdk-dev] [PATCH] eal: force gcc to inline rte_movX function

Chen, Junjie J junjie.j.chen at intel.com
Wed Apr 18 04:43:09 CEST 2018


Thanks to point this out. I agree for the title change.

Do you want me to send v2 patch? Or you can handle it when committing? 

> > > Sometimes gcc does not inline the function despite keyword *inline*,
> > > we obeserve rte_movX is not inline when doing performance profiling,
> > > so use *always_inline* keyword to force gcc to inline the function.
> > >
> > > Signed-off-by: Chen, Junjie <junjie.j.chen at intel.com>
> > > ---
> > >  .../common/include/arch/x86/rte_memcpy.h           | 22
> +++++++++++-----------
> > >  1 file changed, 11 insertions(+), 11 deletions(-)
> >
> > The title should start with "eal/x86:"
> > Something like that:
> > 	eal/x86: force inlining of memcpy sub-functions
> >
> > Bruce, Konstantin, any review of the content/optimization?
> >
> No objection here.
> 
> Acked-by: Bruce Richardson <bruce.richardson at intel.com>



More information about the dev mailing list