[dpdk-dev] [PATCH v2 1/2] net/pcap: physical interface MAC support

[Kuusisaari, Juhamatti]

> >> Why a build time config option for this? Can we make it a runtime devarg?
> >
> > Sure, we can make it a devarg. Or do we even need that? Are there a lot of
> test dependencies that would need to be fixed if we have it enabled by
> default?
> 
> Not test dependencies but this may be overkill for some usecases, I prefer
> making this dynamically configurable, no strong opinion though.

OK, I'll take a look at this and craft a new version.
 
> >
> >> Overall we are trying to reduce config options already and this seems
> >> no need to be build time option at all.
> >>
> >> btw, this is a little late in release cycle, so lets target this
> >> patch for next release.
> >
> > The patch is on top of net-next, this should be just fine.
> 
> Perhaps we should rename the sub-tree :) because this is not happening first
> time. next-net is not for next release, as it has been Linux, it is for this
> release but just a sub-tree for net PMDs.

Aha, while reading the docs it says: "All sub-repositories are merged into main repository for -rc1 and -rc2", so I kind of thought this sub-repo is going to the next release, as you have rc2 out already.

> >
> >> Thanks,
> >> ferruh
> >

Thanks,
--
 Juhamatti