[dpdk-dev] [PATCH v2 2/2] devtools: improve kernel script execution check

Juhamatti Kuusisaari Juhamatti.Kuusisaari at coriant.com
Thu Apr 19 14:00:03 CEST 2018


Handle properly a case where DPDK_MAINTAINER_PATH is set
to point to a directory.

Signed-off-by: Juhamatti Kuusisaari <juhamatti.kuusisaari at coriant.com>
---
 devtools/get-maintainer.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/devtools/get-maintainer.sh b/devtools/get-maintainer.sh
index 1e9eabd..b916048 100755
--- a/devtools/get-maintainer.sh
+++ b/devtools/get-maintainer.sh
@@ -23,7 +23,8 @@ print_usage () {
 }
 
 # Requires DPDK_GETMAINTAINER_PATH devel config option set
-if [ ! -x "$DPDK_GETMAINTAINER_PATH" ] ; then
+if [ ! -f "$DPDK_GETMAINTAINER_PATH" ] ||
+   [ ! -x "$DPDK_GETMAINTAINER_PATH" ] ; then
 	print_usage >&2
 	echo
 	echo 'Cannot execute DPDK_GETMAINTAINER_PATH' >&2
-- 
2.8.1



More information about the dev mailing list